Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #30] modify mappers and add test #31

Closed
wants to merge 1 commit into from

Conversation

Lambert-Rao
Copy link
Contributor

improved connection, connector, client, meta, health mappers and add their unit tests.

improved connection, connector, client, meta, health mappers and add their unit tests.
@Pil0tXia
Copy link
Member

Pil0tXia commented Feb 7, 2024

plz check ci

@Lambert-Rao
Copy link
Contributor Author

CI failed for database test, I have tested them successfully locally, if unit tests are still unavaiiable, I will remove them.

@Pil0tXia
Copy link
Member

@Lambert-Rao

You may pull mysql docker image in Github workflow to run unit tests.

@Pil0tXia Pil0tXia deleted the branch apache:develop February 18, 2024 14:40
@Pil0tXia Pil0tXia closed this Feb 18, 2024
@Pil0tXia
Copy link
Member

Please submit the PR to dev branch instead of develop branch.

I should have changed this PR's merge destination to dev before deleting develop branch.

@Pil0tXia
Copy link
Member

Pil0tXia commented Feb 18, 2024

Besides, you may change the database name, username and password to EVENTMESH_DASHBOARD, root and password in config to run unit tests after #32 has accomplished.

@Lambert-Rao
Copy link
Contributor Author

Besides, you may change the database name, username and password to EVENTMESH_DASHBOARD, root and password in config to run unit tests after #32 has accomplished.

@Pil0tXia
I have used eventmesh-dashboard-test as the test database name, is there a specific reason for using EVENTMESH_DASHBOARD? If not, I would edit your ci file.
Also, should the test database host be localhost?

@Pil0tXia
Copy link
Member

Using - in the database name is not a best practice as it is recommended to use _.

You can try localhost first and see if the application can establish a connection with the container. If it fails, we need to set a MYSQL_ADDR environment variable and use 127.0.0.1 as the MySQL host in GitHub Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants